Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: disabling livenessProbes creates corrupted manifests #47

Open
aarbesser opened this issue Oct 31, 2024 · 0 comments · May be fixed by #49
Open

bug: disabling livenessProbes creates corrupted manifests #47

aarbesser opened this issue Oct 31, 2024 · 0 comments · May be fixed by #49
Labels
bug Something isn't working

Comments

@aarbesser
Copy link
Contributor

While one can set livenessEnabled to false, this creates a manifest with an "empty" livenessProbe:
livenessProbe: {}

This gets rejected by Kubernetes:

The Deployment "kvoltoweb-plone-backend-deployment-c884a954" is invalid: spec.template.spec.containers[0].livenessProbe: Required value: must specify a handler type

Disabling livenessProbes would need to remove it from the manifest completely, including the key.
@jensens jensens added the bug Something isn't working label Oct 31, 2024
jensens added a commit that referenced this issue Oct 31, 2024
@jensens
fixes #47
fa21d75
@jensens jensens linked a pull request Oct 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bug issue 47 disabling livenessProbes creates corrupted manifests bluedynamics/cdk8s-plone
2 participants
@jensens @aarbesser