Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send initiateMmtMultisigTest when loading a wallet #6

Open
nikolai-b opened this issue May 28, 2018 · 2 comments
Open

Send initiateMmtMultisigTest when loading a wallet #6

nikolai-b opened this issue May 28, 2018 · 2 comments

Comments

@nikolai-b
Copy link
Member

Along with #5 it would be good to offer to send an initiateMmtMultisigTest message when a wallet is loaded that hasn't go an initiateMmtMultisigTest message already.

@ameba23
Copy link
Member

ameba23 commented Jun 5, 2018

this one is driving me crazy. much like the problem with the transactions, i cant find a way to uniquely identify the wallet. getMpk gives a different master public key for each cosigner. the electrum gui will give us master public keys of all cosigners which is what we need here.

we could use listAddresses to find some matching addresses. i have the feeling this is unreliable but its the best i can come up with right now. the txid of the wallet's oldest transaction? only works when there is already a transaction so not much use.

@ameba23
Copy link
Member

ameba23 commented Jun 17, 2018

publishing these init messages is now implemented.

as a work-around the wallet is identified by finding our mpk, but this is not great because we can only verify our own mpk not that of our cosigners, and in principle its possible to use this for more than one wallet (not a unique identifier). Once we are not relying on electrum i would suggest using the hash of concatonating all cosigners mpks together.

currently using:

function identifyWallet(allWallets, mpk) {
  return Object.keys(allWallets).find(function(aWallet) {
    return Object.keys(allWallets[aWallet].xpub).indexOf(mpk) > -1;
  });
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants