From 500ec33658bedad8b2b35f8d933893ab9e341bca Mon Sep 17 00:00:00 2001 From: Louis Kirkham Date: Fri, 5 May 2023 15:58:28 +0100 Subject: [PATCH 001/352] Remove banner from dashboard --- .../info_messages/_award_season_closed.html.slim | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/app/views/content_only/info_messages/_award_season_closed.html.slim b/app/views/content_only/info_messages/_award_season_closed.html.slim index 2da270193b..3b2026d63b 100644 --- a/app/views/content_only/info_messages/_award_season_closed.html.slim +++ b/app/views/content_only/info_messages/_award_season_closed.html.slim @@ -1,15 +1,5 @@ article.group role="article" div - .govuk-notification-banner role="region" aria-labelledby="govuk-notification-banner-title" data-module="govuk-notification-banner" - .govuk-notification-banner__header - .govuk-notification-banner__title#govuk-notification-banner-title - | Important - .govuk-notification-banner__content - p.govuk-notification-banner__heading.name-change-notification - | We are delighted to announce that the name of these Awards has changed to The King's Awards for Enterprise. The first King's Awards will be announced on 21 April 2023, The Late Queen Elizabeth II's birthday. Please see the - =<> link_to "official press notice", "https://www.gov.uk/government/news/king-charles-iii-continues-queen-elizabeths-legacy-by-giving-his-majestys-name-to-prestigious-awards", target: '_blank' - | for further details. - .application-notice.info-notice p.govuk-body = render "content_only/info_messages/new_users_message" From a365e19034c07e06463ee8d4c65864a629afb939 Mon Sep 17 00:00:00 2001 From: Vasili Kachalko Date: Wed, 21 Jun 2023 13:47:16 +0200 Subject: [PATCH 002/352] tweak case status report --- Gemfile.lock | 5 +++++ app/models/reports/cases_status_report.rb | 4 ++-- app/models/reports/form_answer.rb | 16 ++++++++++++++-- 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 58c7508f10..1c637713a3 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -482,6 +482,7 @@ GEM mime-types-data (~> 3.2015) mime-types-data (3.2023.0218.1) mini_mime (1.1.2) + mini_portile2 (2.8.2) minitest (5.18.0) money (6.16.0) i18n (>= 0.6.4, <= 2) @@ -503,6 +504,9 @@ GEM activerecord (>= 4.0.0) activesupport (>= 4.0.0) nio4r (2.5.9) + nokogiri (1.14.3) + mini_portile2 (~> 2.8.0) + racc (~> 1.4) nokogiri (1.14.3-x86_64-darwin) racc (~> 1.4) nokogiri (1.14.3-x86_64-linux) @@ -834,6 +838,7 @@ GEM zxcvbn (0.1.9) PLATFORMS + ruby x86_64-darwin-21 x86_64-linux diff --git a/app/models/reports/cases_status_report.rb b/app/models/reports/cases_status_report.rb index b47c9023ab..9da2ac08c9 100644 --- a/app/models/reports/cases_status_report.rb +++ b/app/models/reports/cases_status_report.rb @@ -67,11 +67,11 @@ class Reports::CasesStatusReport method: :overall_status }, { - label: "ACReceived", + label: "Additional Financials Received", method: :ac_received }, { - label: "ACChecked", + label: "Additional Financials Checked", method: :ac_checked }, { diff --git a/app/models/reports/form_answer.rb b/app/models/reports/form_answer.rb index 9d5c2ebe02..1613a0ccb5 100644 --- a/app/models/reports/form_answer.rb +++ b/app/models/reports/form_answer.rb @@ -76,11 +76,19 @@ def press_release_updated end def ac_received - bool obj.audit_certificate.present? + if po_sd_provided_actual_figures? + "N/A - provided actual figures" + else + bool obj.audit_certificate.present? + end end def ac_checked - bool obj.audit_certificate.try(:reviewed?) + if po_sd_provided_actual_figures? + "N/A" + else + bool obj.audit_certificate.try(:reviewed?) + end end def case_assigned @@ -223,4 +231,8 @@ def case_summary_status def overall_status obj.state.humanize end + + def po_sd_provided_actual_figures? + %w[mobility development].include?(obj.award_type) && obj.document["product_estimated_figures"] == "no" + end end From 7364d75ee1c5e8e560ea8a8116adb9d8d7acb9ec Mon Sep 17 00:00:00 2001 From: Nickolay Loshkarev Date: Wed, 21 Jun 2023 16:21:58 +0400 Subject: [PATCH 003/352] Fix DEPRECATION WARNING to skip_pipeline for assets --- Gemfile.lock | 5 ++++- app/views/layouts/govuk_template.html.erb | 18 +++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 58c7508f10..d36350301b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -503,6 +503,8 @@ GEM activerecord (>= 4.0.0) activesupport (>= 4.0.0) nio4r (2.5.9) + nokogiri (1.14.3-arm64-darwin) + racc (~> 1.4) nokogiri (1.14.3-x86_64-darwin) racc (~> 1.4) nokogiri (1.14.3-x86_64-linux) @@ -834,6 +836,7 @@ GEM zxcvbn (0.1.9) PLATFORMS + arm64-darwin-21 x86_64-darwin-21 x86_64-linux @@ -942,4 +945,4 @@ RUBY VERSION ruby 2.7.7p221 BUNDLED WITH - 2.4.8 + 2.4.4 diff --git a/app/views/layouts/govuk_template.html.erb b/app/views/layouts/govuk_template.html.erb index 903d250f9b..fce0c17c7e 100644 --- a/app/views/layouts/govuk_template.html.erb +++ b/app/views/layouts/govuk_template.html.erb @@ -20,8 +20,8 @@