-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tightly coupled components refactory #42
Labels
enhancement
New feature or request
Comments
EnricoBarbieri1997
assigned zheleznov163 and giorgionocera and unassigned giorgionocera
Jun 21, 2022
EnricoBarbieri1997
added
medium priority
After all high priority tasks are closed or stalled
and removed
medium priority
After all high priority tasks are closed or stalled
labels
Jun 21, 2022
I will provide an initial list with examples of which ones are fine and which ones are not as soon as possible |
giorgionocera
added
the
medium priority
After all high priority tasks are closed or stalled
label
Jun 21, 2022
Examples of it are:
|
zheleznov163
added a commit
that referenced
this issue
Jul 7, 2022
zheleznov163
added a commit
that referenced
this issue
Jul 7, 2022
EnricoBarbieri1997
added
low priority
After all medium priority tasks are closed or stalled
enhancement
New feature or request
and removed
medium priority
After all high priority tasks are closed or stalled
low priority
After all medium priority tasks are closed or stalled
labels
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Components (in particular the ones inside BottomSheet) needs to be refactored because some are tightly coupled with stores, outer most components and BottomSheet. For the ones tightly coupled with stores or controllers is enough to have a version where everything is a prop and a version that calculates the current logic and passes it down as prop.
Not every component that access stores or models directly needs to be changed but there are a lot of general components that can't be reused because instead of having generic event handlers they have a very specific model passed to it
The text was updated successfully, but these errors were encountered: