Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alert Error View #116

Open
zheleznov163 opened this issue Sep 1, 2022 · 2 comments
Open

Add Alert Error View #116

zheleznov163 opened this issue Sep 1, 2022 · 2 comments
Assignees
Labels
high priority After all urgent tasks are closed or stalled

Comments

@zheleznov163
Copy link

zheleznov163 commented Sep 1, 2022

Add a global error notification. You need to decide how long the message will last. It's probably best to only display if there are errors in the open bottomsheet, and hide it when trying to collapse the bottomsheet.

Снимок экрана 2022-09-01 в 16 13 04

@zheleznov163 zheleznov163 self-assigned this Sep 1, 2022
zheleznov163 added a commit that referenced this issue Sep 1, 2022
zheleznov163 added a commit that referenced this issue Sep 1, 2022
zheleznov163 added a commit that referenced this issue Sep 1, 2022
@EnricoBarbieri1997
Copy link
Collaborator

I agree that it should close automatically when no bottom sheet is open. Furthermore we should provide a method that accepts the error text or an array of errors and automatically opens it when the array is not empty or the string is not empty and closes it otherwise.

@EnricoBarbieri1997 EnricoBarbieri1997 added the high priority After all urgent tasks are closed or stalled label Sep 7, 2022
zheleznov163 added a commit that referenced this issue Sep 8, 2022
zheleznov163 added a commit that referenced this issue Sep 8, 2022
@EnricoBarbieri1997
Copy link
Collaborator

It's not a bad implementation but if the message is set while no modal is open (maybe an async request started and then the modal was closed by the user) the alert is going to show up anyway. Also the current closing animation feels strange, it fades and then blinks back to fully visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority After all urgent tasks are closed or stalled
Projects
None yet
Development

No branches or pull requests

2 participants