You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Spaces are converted to underscores as convenience for the keys, but the original value is also saved as a key, and both copies point to the value. i.e. we have this:
This needs to be refactored to only provide valid types (no underscores); it was done like this for ease of use but the duplicate keys make iteration difficult/filtering necessary in some places. Also becomes confusing seeing underscores in some places and spaces in others.
The text was updated successfully, but these errors were encountered:
Issue type
Brief description
The
Order
model comes with 2 object keys,types
andstatuses
built here: https://github.com/bitfinexcom/bfx-api-node-models/blob/master/lib/order.js#L728Spaces are converted to underscores as convenience for the keys, but the original value is also saved as a key, and both copies point to the value. i.e. we have this:
This needs to be refactored to only provide valid types (no underscores); it was done like this for ease of use but the duplicate keys make iteration difficult/filtering necessary in some places. Also becomes confusing seeing underscores in some places and spaces in others.
The text was updated successfully, but these errors were encountered: