Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 66 #1706

Closed
axpoems opened this issue Jan 15, 2025 · 2 comments
Closed

For Cycle 66 #1706

axpoems opened this issue Jan 15, 2025 · 2 comments
Labels
team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@axpoems
Copy link

axpoems commented Jan 15, 2025

Summary

  • BSQ requested: 7056.45
  • USD requested: 17500
  • BSQ rate: 2.48 USD per BSQ
  • Previous compensation request: For Cycle 65 #1686

Contributions delivered

Title Team USD Link Notes
Bisq 2 PR:
Add channel icons to user profile card messages list
dev bisq-network/bisq2#3099
Bisq 2 PR:
Improvements in user profile card messages list
dev bisq-network/bisq2#3098 • Show placeholder text when user profile has no messages.
• Improve styles in messages list.
• Set placeholder text in user profile card reputation table.
Bisq 2 PR:
Add messages tab to user profile card
dev bisq-network/bisq2#3097 Resolves #2671
• Add a new tab in the user profile card to show user public chats sent messages.
Bisq 2 PR:
Move go to offer logic to controller
dev bisq-network/bisq2#3094
Bisq 2 PR:
Move price formatting strings to application resource file
dev bisq-network/bisq2#3093
Bisq 2 PR Review:
#3090
dev bisq-network/bisq2#3090 ACK
Bisq 2 PR:
Fix cropping when using integer numbers
dev bisq-network/bisq2#3088 • Fix partial cropping when using integer numbers in amount and price text input fields.
Bisq 2 PR:
Restrict amount and price text fields to accept only numbers
dev bisq-network/bisq2#3087 • Prevent input of anything other than numbers with optional floating point in both amount and price text input fields.
Bisq 2 PR:
Allow reporting a user profile everywhere in the app
dev bisq-network/bisq2#3085 Resolves #3073
• Chat channel domain is a required field in to report to moderator protobuf message.
• To have the flexibility to report a user profile anywhere in the app while ensuring backwards compatibility, Support is used as the default domain for these cases.
Bisq 2 PR:
Unify amount and price input fields
dev bisq-network/bisq2#3082 • Make base amount only readable.
• Decouple big and small input amounts.
Bisq 2 PR:
Add logic to apply default price at create offer
dev bisq-network/bisq2#3081 • At create offer, market price is suggested by default. From then on, the last used price is saved in a cookie and reused.
• Position cursor at the end of the price text input when requesting focus.
• Hide back/next buttons when showing amount info overlay.
• Fix price strings in review offer.
Bisq 2 PR:
Improvements in trade wizard
dev bisq-network/bisq2#3080 • Align amount info overlay position.
• Update strings in price selection component.
• Request focus when swapping between fixed and range amounts.
Bisq 2 PR:
Open profile card from mediator table
dev bisq-network/bisq2#3079 Resolves #3076
Bisq 2 PR:
Fix market selection menu for OS cross-compatibilty
dev bisq-network/bisq2#3078 • Use Bisq popup instead of a context menu to fix issues with font sizes between different OS.
Bisq 2 PR:
Limit char count in price selection
dev bisq-network/bisq2#3069 • Limit the number of characters that can be added in the price selection text field.
Bisq 2 PR:
Revise market selection experience
dev bisq-network/bisq2#3068 • Increase visibility of market selection in step one of the trade wizard.
Bisq 2 PR:
Add price slider in trade wizard
dev bisq-network/bisq2#3067 • Add price slider to select price at create offer.
• Fix precision in amount selection small input number.
Bisq 2 PR:
Limit char count in amount selection
dev bisq-network/bisq2#3066 • Limit the number of characters that can be added in the amount selection text field.
Bisq 2 PR:
Fix issues with max amount info
dev bisq-network/bisq2#3065 Fixes #3051
• Fix calculating max allowed amount.
• Update max allowed amount every time a new market is selected market.
Bisq 2 PR:
Improvements in amount selection
dev bisq-network/bisq2#3063 • Use different description string for fixed and range amounts.
• Use green font in description when component is active (matching price component).
• Fix base amount tooltip.
Bisq 2 PR:
Consolidate amount and price in create offer wizard
dev bisq-network/bisq2#3057 • Simplify the create offer flow down to three steps plus review: steps amount & price are now merged into one.
• Amount range selection is now done in the same input field, and slider has two pickers which use arrows instead of a knob. The latter has the added benefit of showing better the selected range and with better precision.
• Add new component to show price (fixed and percentage) with the same design style as amount.
dev 17500 Total

[*] Includes all the UX and graphical design work.

@axpoems
Copy link
Author

axpoems commented Jan 15, 2025

ced599943181de376d78fb7f5e88cdfcaa848ba3f40e0c592002f6f864fc68d5

@MwithM MwithM added this to the Cycle 66 milestone Jan 16, 2025
@MwithM MwithM moved this to In Progress in Compensation Request Board Jan 16, 2025
@MwithM MwithM moved this from In Progress to In Review in Compensation Request Board Jan 16, 2025
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Jan 24, 2025
@MwithM
Copy link
Contributor

MwithM commented Jan 24, 2025

Closed as accepted.

@MwithM MwithM closed this as completed Jan 24, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed in Compensation Request Board Jan 24, 2025
@MwithM MwithM added the team:dev https://bisq.wiki/Dev_Team label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

2 participants