-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom database tables to get full speed optimization #8
Comments
I am very interested in this as there should be a large performance improvement in doing such queries on a custom flattened meta table, such as created by the MB Custom Table extension from metabox.io. Naturally, the next step would be to add the custom table support mentioned in this thread. Just wanted to join and collect any thoughts on how best to proceed on this. Have any ideas on this been sketched out or documented in any way since the thread was started back in 2017? Would it be best to extend or filter the WP_Query / WP_User_Query to include the custom table, or better to write a custom SQL query? If the latter, how best to deal with implement a cache layer? Since a custom table could hold much more meta data than just lat and lng, it would be ideal to extend the WHERE clause to allow filtering the results by other meta details. Regardless, thank you for the great plugin, and I look forward to helping any way I can. |
Great, @baden03 your input is greatly appreciated. The design is still open, but in general I would prefer filtering the That way we can adjust e.g. the main queries if needed. Looking at the implementation of One could also look at joining tables versus subqueries versus multiple queries. There's e.g. an interesting filter But as a first try I would go with the usual table joining. Should the plugin allow creation of such a custom table? Or should it assume existing custom tables. Or both? I think assuming an existing table, would be a good first step. What do you think? Creating a script to create and generate a demo table and corresponding posts, would be a good starting point, it would also help with unit testing. |
Version 0.2.0 is out with an updated README on custom tables.
|
To get the full optimization speed, we should support the
geo_query
ofWP_Query
to read data from a custom database tables.The text was updated successfully, but these errors were encountered: