Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story doesn't cover the whole screen on android #107

Closed
AlekseyP18 opened this issue Aug 8, 2024 · 1 comment · Fixed by #122
Closed

Story doesn't cover the whole screen on android #107

AlekseyP18 opened this issue Aug 8, 2024 · 1 comment · Fixed by #122
Assignees

Comments

@AlekseyP18
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @birdwingo/[email protected] for the project I'm working on.

The problem is only on android platform. The story screen doesn't cover the whole screen with status bar and navigation

So it looks like this
Screenshot 2024-08-07 at 16 43 39

After my fix it's like

Screenshot 2024-08-08 at 09 11 10

Please create a small fix to solve this problem. Thanks!

Here is the diff that solved my problem:

diff --git a/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx b/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx
index 873c3b9..56dce43 100644
--- a/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx
+++ b/node_modules/@birdwingo/react-native-instagram-stories/src/components/Modal/index.tsx
@@ -453,7 +453,7 @@ const StoryModal = forwardRef<StoryModalPublicMethods, StoryModalProps>( ( {
   );
 
-    <Modal visible={visible} transparent animationType="none" testID="storyRNModal" onRequestClose={onClose}>
+    <Modal visible={visible} statusBarTranslucent transparent animationType="none" testID="storyRNModal" onRequestClose={onClose}>

diff --git a/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts b/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts
index 4ea5850..d36284d 100644
--- a/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts
+++ b/node_modules/@birdwingo/react-native-instagram-stories/src/core/constants/index.ts

-export const { width: WIDTH, height: HEIGHT } = Dimensions.get( 'window' );
+export const { width: WIDTH, height: HEIGHT } = Dimensions.get( 'screen' ); 
 

This issue body was partially generated by patch-package.

@AlekseyP18
Copy link
Author

The ts is throwing error for import in the following file - components/Image/index.tsx

import { StoryItemProps } from '~/core/dto/instagramStoriesDTO'; => import { StoryItemProps } from '../../core/dto/instagramStoriesDTO';

could you fix it also please

@LukasFridmansky LukasFridmansky self-assigned this Oct 8, 2024
@LukasFridmansky LukasFridmansky linked a pull request Oct 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants