Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Enhancement: Allow geneset creation with IDs other than MyGene IDs #70

Open
ravila4 opened this issue Nov 12, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@ravila4
Copy link
Contributor

ravila4 commented Nov 12, 2022

Currently, MyGeneset's user_genesets endpoint expects a list of gene IDs that are MyGene primary IDs: https://github.com/biothings/mygeneset.info/blob/master/src/web/handlers/api.py#L80-L86. This is because the frontend app only uses mygene ids for lookup.

However, if we want to expand the usefulness of the API, we can enable this endpoint to accept any kind of ids. The utilities module mygene_lookup already supports creating a geneset from any type of ID (it's being used by the various data plugins).

It would just be a matter of changing the _query_mygene function in api.py to take a parameter to allow specifying the type of input id for the input gene list. It could be an id_type parameter to POST requests, accepting a string or comma-separated list of input id types.

@ravila4 ravila4 changed the title Enhancement: Allow geneset creation with IDs other than MyGene IDs API Enhancement: Allow geneset creation with IDs other than MyGene IDs Nov 12, 2022
@ravila4 ravila4 added the enhancement New feature or request label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant