Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

punchable_type string limit 20 #32

Open
PositiveControl opened this issue May 19, 2021 · 0 comments
Open

punchable_type string limit 20 #32

PositiveControl opened this issue May 19, 2021 · 0 comments

Comments

@PositiveControl
Copy link

Is there a reason for punchable_type having limit => 20 character string in the db migration?

With nested/name-spaced models, this creates an issue:
Example Punchable class: Internal::Board::Event (22 chars)

ActiveRecord::ValueTooLong: Mysql2::Error: Data too long for column 'punchable_type'

To fix the issue for my purpose, I rolled back the punches migration, removed the character limit, then migrated. No issues so far.

I'd be happy to submit an PR/MR to address this, but want to make sure that 20 char limit isn't there for a specific reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PositiveControl