Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axes and lists not included in some processing classes #6

Open
petebankhead opened this issue Dec 8, 2021 · 1 comment
Open

Axes and lists not included in some processing classes #6

petebankhead opened this issue Dec 8, 2021 · 1 comment

Comments

@petebankhead
Copy link
Contributor

In <= v0.4.0 some information is missing from classes in the io.bioimage.specification.transformation.transformation package.

For example ZeroMeanUnitVarianceTransformation only permits a single mean and standard deviation. However the spec here suggests these these should be arrays/lists, and an axes value should be supported as well. This means that it's not currently possible to specify using mean/std on a per-channel basis.

ScaleLinearTransformation (a possible alternative) and ScaleMinMaxTransformation have similar limitations.

I can think of two main ways to fix it:

  • Update relevant methods (e.g. public Number getMean(); public void setMean(Number mean);) to work with either arrays or lists, rather than individual numbers, and also add axes support - but this will be an API-breaking change
  • Deprecate the current methods, and add new ones - but this would require different naming (e.g. getMeans()) that could deviate from other implementations
@tomburke-rse
Copy link
Contributor

We can absolutely convert the Transformations in a way to handle lists. For the IO classes in anything <=0.4.0 we just have to make sure that we transfer from a PRIMITIVE to List and vice versa so that there is only a single implementation of each transformation that handles a list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants