Unignore doctests where possible #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
rukai
force-pushed
the
unignore_doctests
branch
from
9a1d2a4
to
222a7e5
Compare
|
alright, I rebased it. |
|
Sorry I missed this, I'll mark it as not stale for now |
|
Because we're in the middle of a big rewrite for bincode 2, I've taken the liberty to implement your change in a different PR: #421 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363
Possibly we would be better off just deleting the examples from Serializer and Deserializer?
I dont mind either way.
I left the zigzag example as ignore because its a pseudocode demonstration and getting it compiling would obscure the intent.