Add tokio-tracing

[bikeshedder]

This is related to #67

[elpiel]

Another consideration for this issue would be to allow tracing on the postgres Pool.
I'm having issue in our async application because we can't use #[instrument] attr. macro to instrument methods and functions which use the postgres Pool because ClientWrapper & Manager do not impl Debug.

I saw in the code that StatementCache does not impl Debug because of the Statement.

What would be a good way to go around this?

[bikeshedder]

@elpiel I just added a PR adding Debug to all deadpool-postgres types. Would this be helpful to you?

• Implement Debug for all deadpool-postgres types #206

[elpiel]

Yes! That's actually a great start, thank you! I was looking into implementing Debug as well but you were very fast to do it 😅

Here's also an idea - rather than not showing the fields that don't have Debug, we can just use a string representation of the type?

[HigherOrderLogic]

Any update on this?

[elpiel]

@HigherOrderLogic it should be possible to replace log with tracing (https://docs.rs/tracing) in the necessary crates.
E.g. for deadpool-postgres there are exactly 3 places that need to be replaces:

https://github.com/bikeshedder/deadpool/blob/ddd9eafa39e0c823315c3b2bff3767abafa0b05f/postgres/src/lib.rs

[bikeshedder]

I'm a tracing-noob so to say. What tracing/logging messages would be needed in deadpool to be more useable?

[bikeshedder]

I'm currently in process of a 0.10 release and if replacing log by tracing solves 90% of the pain I'm more than happy to include it in this release: https://github.com/bikeshedder/deadpool/tree/milestone/v0.10

[elpiel]

A good starting point IMO is to just replace log with tracing everywhere.
I don't know what new logging messages would be beneficial though.

[HigherOrderLogic]

I'm currently in process of a 0.10 release and if replacing log by tracing solves 90% of the pain I'm more than happy to include it in this release: milestone/v0.10

Thanks for the update. Can I open a PR to replace log with tracing as the first step?

[bikeshedder]

Sure. Please create a PR against the milestone branch.