Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning on first error #1

Open
wvpv opened this issue Apr 15, 2018 · 0 comments
Open

Returning on first error #1

wvpv opened this issue Apr 15, 2018 · 0 comments

Comments

@wvpv
Copy link

wvpv commented Apr 15, 2018

Hey, I'm curious why you break out of the entire function with the return when you encounter one file that doesn't exist or if the download of the file fails.

Seems like you'd want to continue iterating.

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L45

https://github.com/bigbitecreative/wordpress-git-content/blob/80571aa7ec636053912a37f9425cf9c1e1862c89/app/Controllers/RouteController.php#L50
@wvpv wvpv changed the title Breaking out of loop on first error Returning on first error Apr 15, 2018
@eliotharper eliotharper mentioned this issue Jun 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wvpv