-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quantmsio and thermorawfileparser #80
Comments
I have a (private) fork of TRFP that already writes the mz_parquet format, which I am happy to contribute |
That is fantastic, I think the best way is to contribute to the new dotnet we are creating https://github.com/compomics/ThermoRawFileParser/tree/dotnetcore. Dotnet is now the platform for the new MSReader, that I think is better to base everything against that. What do you think? |
Should be easy enough, I have it on dotnet 7 right now. |
@lazear if you can modify that branch with the parquet implementation making sure it matches your specification and quantms.io specification. I can try to trigger the benchmark. |
Cool. FYI I started playing around with ways to store both spectra and chromatograms in |
@lazear would be cool to merge your branch with this branch in TRFP https://github.com/compomics/ThermoRawFileParser/tree/dotnetcore |
So it turns out that what I have is not a fork of TRFP but a separate implementation in C#. Let me see if I can adapt it |
That would be great, we are trying to work to release a new dotnet version of TRFP. |
@lazear, thanks for the PR. Last time we discussed mz_parquet and the alignment between your representation in mz_parquet and quantms.io representation (which I decided to adopt yours), you mentioned you have a private version. will be trying to push to update the representation. My question is: Is the TRFPe the latest version of the mz_parquet definition? |
Yes, this is the most recent version. |
We have a schema for mz data, which is similar to @lazear representation issue #57. We are moving thermorawfileparser to dotnet and it would be great to take the opportunity to include this parquet representation on it. I recommend the following roadmap:
The text was updated successfully, but these errors were encountered: