Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the MultiEmailIput component interactions. #2359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 25, 2024

Fixes #2358

Description

  • Sets the dropdown menu open only when there's some text in the input field.
  • When pasting some text, an email will be added only if it's a valid email or sets the pasted content as the input value so that user can finish or edit the pasted content.

multiemailinput-improvements

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

…cal state will be set to true only when the input has some content.
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2359 October 25, 2024 11:29 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 25, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-1f4k-pr-2359 October 25, 2024 11:46 Inactive
@deepakjosp
Copy link
Contributor Author

@josephmathew900 _a pleases review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to the MultiEmailInput component
2 participants