Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GDD "custom widgets disabled in ranked games" #3879

Closed
SethDGamre opened this issue Oct 26, 2024 · 4 comments
Closed

Implement GDD "custom widgets disabled in ranked games" #3879

SethDGamre opened this issue Oct 26, 2024 · 4 comments
Labels
Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) Enhancement New feature or request UI Everything related UI, GUI, etc.

Comments

@SethDGamre
Copy link
Collaborator

SethDGamre commented Oct 26, 2024

Description

Custom widgets are enableable and enabled by default in ranked games still.

Why?

"Modding is 100% encouraged, it is the lifeblood of game longevity. Mods must enhance the game experience for the player, but not degrade the game experience for other players.

Mods are split into four categories:

Game mods: these change the gameplay and are non-client side, every player must have them.
Cosmetic mods: these change the visual and audio appearance of the game, and are client side.
Interface mods: these change the UI for the player who has them, and are client side.
Automation mods: these issue commands on behalf of the player, and are client side.

In ranked games, all mods are restricted except for cosmetic mods.This is so that no player has an unfair advantage over the others, and to provide a curated game experience."
-from the game design document

What area of the game does this feature request pertain?

Gameplay

Other (optional)

No response

@SethDGamre SethDGamre added Enhancement New feature or request Good First Issue Good for newcomers UI Everything related UI, GUI, etc. labels Oct 26, 2024
@github-actions github-actions bot added the Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) label Oct 26, 2024
@SethDGamre SethDGamre added Approved Approved for implementation by the Game Design Team Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) and removed Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) Approved Approved for implementation by the Game Design Team labels Oct 26, 2024
@RebelNode RebelNode removed the Good First Issue Good for newcomers label Oct 31, 2024
@nevniv
Copy link
Contributor

nevniv commented Oct 31, 2024

I have to agree with Hayaji's comment.. discouraging widget use will discourage widget creation and they add to the game as many are integrated into the game as QoL improvements (ex. Factory Quotas). Turning it off for ranked games is turning it off for practically everything.

If you do decide to go forward with this, I ask that when an AI is present, widgets are still enabled at least. I know that AI matches are not ranked no matter what, but in chobby it still says ranked game = 1 in them so I'm concerned widgets will still be off depending on the implementation.

@drivver44
Copy link
Collaborator

I have to agree with Hayaji's comment.. discouraging widget use will discourage widget creation and they add to the game as many are integrated into the game as QoL improvements (ex. Factory Quotas). Turning it off for ranked games is turning it off for practically everything.

If you do decide to go forward with this, I ask that when an AI is present, widgets are still enabled at least. I know that AI matches are not ranked no matter what, but in chobby it still says ranked game = 1 in them so I'm concerned widgets will still be off depending on the implementation.

the goal is to set what a default match should look like, not what the idea for everyones match is supposed to look like.

@nevniv
Copy link
Contributor

nevniv commented Oct 31, 2024

Sure, but if you made unit market = 1 the default, the vast majority of people would just leave it on. This is the same situation. If you disable widgets, I think they will most likely be off more than on.

Maybe not, maybe people who really want them will try to turn them on and deal with explaining what they are to people who don't know what they're voting for. Maybe it will raise awareness of widgets, it could be a good thing.

@SethDGamre
Copy link
Collaborator Author

From GDT Minutes:
The GDT is amending the decision that all custom widgets should be disabled by default for ranked play. Many BAR mainstays started their lives as custom widget mods. Until proper mod support and whitelist infrastructure is added, the intermediary is deemed necessary. That will be:
The boolean modoption to "Allow Custom Widgets" will become a dropdown menu with the following options:
Cosmetic Only (Default)
Tooltip: UI, informative, reskinning

All
Tooltip: Automation and Cosmetic
When Cosmetic Only is selected, any widget that uses a call-in that issues orders on behalf of the player is disabled at runtime. Examples of such call-ins can be found here: https://springrts.com/wiki/Lua_UnsyncedCtrl#Give_Order

@SethDGamre SethDGamre closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting GDT Approval Awaiting approval from the Game Design Team (game mechanics, balance only) Enhancement New feature or request UI Everything related UI, GUI, etc.
Projects
None yet
Development

No branches or pull requests

4 participants