Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The frigs have less air vision than ground vision? #3844

Open
MeSaber opened this issue Oct 14, 2024 · 2 comments
Open

The frigs have less air vision than ground vision? #3844

MeSaber opened this issue Oct 14, 2024 · 2 comments
Labels
Awaiting BLT Approval Approval needed from the balance team Bug Something isn't working Good First Issue Good for newcomers Unit Def Issues with unit definition files

Comments

@MeSaber
Copy link

MeSaber commented Oct 14, 2024

Description

Whats up with that? :)

image
image
image
(Brimstone without AirLOS so the missile misses every shot unless pinpointers)

Edit: Flamer ship also, not Lightning ship however. Great discrepancy here as both these ships have AA weapon.

Expected Behaviour

Equal airlos or normal (1.5x LOS). Balance issue?

Actual Behaviour

Less AirLOS than LOS.

Reproduction steps

No response

Other

In-game the AirLOS is omitted in details probably because its less than LOS.

@MeSaber MeSaber added the Bug Something isn't working label Oct 14, 2024
@SethDGamre SethDGamre added Good First Issue Good for newcomers Unit Def Issues with unit definition files labels Oct 14, 2024
@saurtron
Copy link
Collaborator

saurtron commented Nov 21, 2024

Checked and this is the current situation:

following ships seem to list less airlos than los at lua files:

  • corfship: los 500, airlos 470 (Brimstone/Anti-Swarm Ship aka Flamer ship)
  • leghastatus: los 500 airlos 470 (Hastatus/Assault Frigate)
  • leghastatusalt: los 500 airlos 470 (alternative Hastatus/Assault Frigate ?)
  • (scavengers) armpshipt3: los 600 airlos 470 (epic ellysaw)

For what I can see these look like the only game units with less airlos than los (I might have overlooked something). Units declaring airlos usually set anywhere between 1x to 4x.

The frigates (armpship/Ellysaw and corpship/Riptide) don't seem to have that problem, they list no specific airlos at lua files but ingame they show 1.5x los. They also have no aa afaics.

Engine indeed seems to set airlos = 1.5*los when airlos is not defined at unitdefs.

To fix this I think we would need some decision from the balance team to see if current situation is wanted, if we should just remove the airlos to let engine set 1.5x, or if we want some specific values.

@WatchTheFort WatchTheFort added the Awaiting BLT Approval Approval needed from the balance team label Nov 21, 2024
@MeSaber
Copy link
Author

MeSaber commented Nov 21, 2024

The frigs been silently fixed it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting BLT Approval Approval needed from the balance team Bug Something isn't working Good First Issue Good for newcomers Unit Def Issues with unit definition files
Projects
None yet
Development

No branches or pull requests

4 participants