This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Rewrite buoy front end using Backbone.js #185
Labels
Milestone
Comments
please edit this. I can't remember everything we discussed. |
CC'ing @mcverter, who's expressed an interest in helping with this process, too. |
@hurtstotouchfire Have a look at #190, which is a PR for the first line item here (which I'm marking "done") because it "improves DOM spaghetti." All I've done is DRY the references to containment-level HTML If more, what else does "improve DOM spaghetti" actually mean? |
I am working on the javascript currently
…On Dec 1, 2016 11:17 PM, "Meitar M." ***@***.***> wrote:
@hurtstotouchfire <https://github.com/hurtstotouchfire> Have a look at
#190 <#190>, which is a PR for
the first line item here (which I'm marking "done") because it "improves
DOM spaghetti." All I've done is DRY the references to containment-level
HTML ids and class attributes.
If more, what else does "improve DOM spaghetti" actually mean?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#185 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R>
.
|
What is being done by you all? Are we working on the same code?
On Dec 1, 2016 11:18 PM, "Mitchell Verter" <[email protected]>
wrote:
… I am working on the javascript currently
On Dec 1, 2016 11:17 PM, "Meitar M." ***@***.***> wrote:
> @hurtstotouchfire <https://github.com/hurtstotouchfire> Have a look at
> #190 <#190>, which is a PR for
> the first line item here (which I'm marking "done") because it "improves
> DOM spaghetti." All I've done is DRY the references to containment-level
> HTML ids and class attributes.
>
> If more, what else does "improve DOM spaghetti" actually mean?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#185 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABYvhLP6twfl29mV9njj5yMSoMDyl7SJks5rD5vWgaJpZM4K8B3R>
> .
>
|
Ah ok. I have been using those css selectors in the backbone.
|
Now that #204 is merged I think our next step with the Backbone stuff is to look at the remaining I've updated the todo list in this issue to reflect that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This rewrite should also improve the isolation of the front end with a view to extracting it into a small JS library that would facilitate possible back-end expansion (see #171, #172). This should also at least partially obsolete #64.
Goals:
buoy-alert.js
) filebuoy-map.js
) file, where it makes senseScope:
The text was updated successfully, but these errors were encountered: