Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"return 0" missing leads to erroneous results... sometimes! #10

Open
Limhes opened this issue Aug 24, 2023 · 3 comments
Open

"return 0" missing leads to erroneous results... sometimes! #10

Limhes opened this issue Aug 24, 2023 · 3 comments

Comments

@Limhes
Copy link
Contributor

Limhes commented Aug 24, 2023

Hi,

I am using your library, which works really well! Thanks for that.

However, I just spent half a day of debugging to find out that a missing "return 0" at the end of FDC1004::triggerSingleMeasurement can lead to the function returning something non-zero, and then the code stops working.

Maybe nice to fix that :)

Thank you,
René

@beshaya
Copy link
Owner

beshaya commented Aug 24, 2023 via email

@Limhes
Copy link
Contributor Author

Limhes commented Aug 26, 2023

I am a bit new to git, but I managed to open a pull request. Let me know if it doesn't work.

Thanks!

@beshaya
Copy link
Owner

beshaya commented Aug 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants