-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When nodes are dragged, labels stay on for that node #31
Comments
hi! yes, this annoys me as well. Thanks for bringing it up. We'll make sure to address this soon-ish! |
It because a drag event is unavoidably also a click event in d3. I tried fixing this a while back but dropped it because of more important issues. The easy fix is to just check if the node moved before a node gets a label, but I need to sit down and implement it in a good way. Traveling at the moment, but will see to this in a matter of weeks. |
maybe we could switch labels on and off by pressing 'L' when hovering? |
I see. You want to substitute a mouseclick for an 'L' click? |
I'll admit it's not very intuitive |
I understand why a drag event is also a click event, but my bigger question is, Why can't you toggle off the label if the node has been dragged, while you can if it's a simple click? |
Not sure if I am interacting with netwulf incorrectly, but after running the following code,
with "Display labels" off, when I drag a node in the visualization, the label stays on the node, even if I click it again. If I don't drag the node, then I can toggle the label on and off just fine. The only way to hide the label on that node again is to turn on the "Display labels" and then turn it off again.
Very minimal importance, but it was unexpected behavior, so I figured I would bring it up.
Great project!
The text was updated successfully, but these errors were encountered: