Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor gradle "reject" versions #759

Open
dalewking opened this issue Mar 31, 2023 · 1 comment
Open

Honor gradle "reject" versions #759

dalewking opened this issue Mar 31, 2023 · 1 comment

Comments

@dalewking
Copy link

Gradle has rich versioning so you can precisely specify versions. Included in that is the ability to specify rejected versions. The dependencyUpdate task should honor that and not suggest upgrading to versions that are rejected.

@ben-manes
Copy link
Owner

This plugin performs a Configuration.copyRecursive() which should include those constraints. We then clear the dependencies, add them again but with a dynamic version, and as Gradle to resolve the versions. The most we do with constraints is allow them to be added as dependency queries for version upgrades, since as you said Gradle does not seem to enforce them. That use-case is for those who want to monitor their transitive dependency versions to keep them at the later baseline version.

For direct dependencies using a resolution strategy is common and we support that. The rejectVersionIf is a convenience for that.

Since we let Gradle do the resolution and perform a copy which should capture everything needed, it seems like you should ask the Gradle folks for clarity. We're simply using their api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants