Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit configuration is based on abandoned project #67

Open
wusatosi opened this issue Oct 2, 2024 · 1 comment
Open

Pre-commit configuration is based on abandoned project #67

wusatosi opened this issue Oct 2, 2024 · 1 comment

Comments

@wusatosi
Copy link

wusatosi commented Oct 2, 2024

In pre-commit's config:

# CMake formatting
- repo: https://github.com/cheshirekow/cmake-format-precommit
rev: "v0.6.13"
hooks:
- id: cmake-format
additional_dependencies: [pyyaml]
- id: cmake-lint

Referenced configuration support project have not been updated in 4 years, and the underlying formatter (cmake_format) have not been updated in 3 years and maybe abandoned.

Same applies for:

- repo: https://github.com/pocc/pre-commit-hooks
rev: v1.3.5
hooks:
- id: clang-format
additional_dependencies: ['clang-format==18.1.8']
# - id: oclint
# - id: cppcheck
# - id: cpplint

Which have not been updated in 4 years, however we might get away with this because this project is just an wrapper for calling underlying formatter.

@wusatosi
Copy link
Author

wusatosi commented Oct 2, 2024

Consider switching to gersemi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant