From 75ee2e3bcef37b755ade4e6a5a4ccbc5e826ec07 Mon Sep 17 00:00:00 2001 From: Sahil Nagpure Date: Fri, 5 Apr 2024 19:29:05 +0530 Subject: [PATCH 1/4] fix-winforms-progressbar --- winforms/src/toga_winforms/widgets/progressbar.py | 1 + 1 file changed, 1 insertion(+) diff --git a/winforms/src/toga_winforms/widgets/progressbar.py b/winforms/src/toga_winforms/widgets/progressbar.py index 40efc73221..e1a8aa85f7 100644 --- a/winforms/src/toga_winforms/widgets/progressbar.py +++ b/winforms/src/toga_winforms/widgets/progressbar.py @@ -21,6 +21,7 @@ class ProgressBar(Widget): TOGA_SCALE = 1000 + _background_supports_alpha = False def create(self): self.native = WinForms.ProgressBar() From 1fce562fa580e9bc1a1116b664393bb5719be763 Mon Sep 17 00:00:00 2001 From: Sahil Nagpure Date: Fri, 12 Apr 2024 11:34:46 +0530 Subject: [PATCH 2/4] modified progressbar.py --- winforms/tests_backend/widgets/progressbar.py | 1 + 1 file changed, 1 insertion(+) diff --git a/winforms/tests_backend/widgets/progressbar.py b/winforms/tests_backend/widgets/progressbar.py index 76b43be525..4aa5a3c2c5 100644 --- a/winforms/tests_backend/widgets/progressbar.py +++ b/winforms/tests_backend/widgets/progressbar.py @@ -5,6 +5,7 @@ class ProgressBarProbe(SimpleProbe): native_class = System.Windows.Forms.ProgressBar + background_supports_alpha = False @property def is_determinate(self): From ad58048d2313280fd572d5757bd5270f12808f23 Mon Sep 17 00:00:00 2001 From: Sahil Nagpure Date: Fri, 12 Apr 2024 11:41:59 +0530 Subject: [PATCH 3/4] added test --- testbed/tests/widgets/test_progressbar.py | 1 + 1 file changed, 1 insertion(+) diff --git a/testbed/tests/widgets/test_progressbar.py b/testbed/tests/widgets/test_progressbar.py index a08e005b16..2f6372ee7d 100644 --- a/testbed/tests/widgets/test_progressbar.py +++ b/testbed/tests/widgets/test_progressbar.py @@ -3,6 +3,7 @@ import toga from .properties import ( # noqa: F401 + test_background_color_transparent, test_enable_noop, test_flex_horizontal_widget_size, ) From b69d78c13b5e83199c1df9c76a21f5adbce94494 Mon Sep 17 00:00:00 2001 From: Sahil Nagpure Date: Fri, 12 Apr 2024 11:44:28 +0530 Subject: [PATCH 4/4] added changenote --- changes/2485.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes/2485.bugfix.rst diff --git a/changes/2485.bugfix.rst b/changes/2485.bugfix.rst new file mode 100644 index 0000000000..ddf0403402 --- /dev/null +++ b/changes/2485.bugfix.rst @@ -0,0 +1 @@ +Exception raised by ProgressBar on Windows regarding transparent background has been resolved.