Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for saving ID3v2.3 #44

Open
JuniorJPDJ opened this issue May 11, 2021 · 2 comments
Open

Tests for saving ID3v2.3 #44

JuniorJPDJ opened this issue May 11, 2021 · 2 comments

Comments

@JuniorJPDJ
Copy link
Contributor

JuniorJPDJ commented May 11, 2021

I think we should have some tests for this as It's supported but not checked if works.
I'm pretty sure big part of multi-valued tags would fail and this should be only expected failure.

@sampsyo
Copy link
Member

sampsyo commented May 11, 2021

That seems like a good idea. For exceptions, this seems straightforward. For other (non-failure) cases, would we just check "round-trip" preservation of data?

@JuniorJPDJ
Copy link
Contributor Author

I was thinking about using same test set as for other formats, just change saving to id3v2.3 for new "format". Would also need to set some failures as expected but it doesn't seem to hard to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants