Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLP flaky integration #1002

Open
cruzdanilo opened this issue Jan 6, 2023 · 0 comments
Open

GLP flaky integration #1002

cruzdanilo opened this issue Jan 6, 2023 · 0 comments

Comments

@cruzdanilo
Copy link

for the GLP vaults, the underlying tokens should be transferred through the sGLP (staked). documentation here: https://gmxio.gitbook.io/gmx/contracts#transferring-staked-glp

the api is returning sGLP's address as the tokenAddress, so the front-end knows which token to transfer, but this has some side-effects. some integrations rely on tokenAddress to display underlying information about positions, and those integrations expect GLP as the underlying. this breaks GLP vaults on zapper, for example.

i think the api should return both addresses, and the front-end already calls this value locally as depositTokenAddress, so this could be a good field name here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant