Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Grid for audit_data? #109

Open
Blizzke opened this issue Jul 14, 2015 · 1 comment
Open

Discussion: Grid for audit_data? #109

Blizzke opened this issue Jul 14, 2015 · 1 comment

Comments

@Blizzke
Copy link
Member

Blizzke commented Jul 14, 2015

The grid would show the entry_id, the type (shown as the panel name), created and a summary of the data-entry that would be provided by the panel itself.
Idea was to split off the summary for the panel labels into a separate function getSummaryStats()-function to also show info in the grid (eg a database entry could show: "80 queries, 1005ms")

Still to be determined:

  • Is it worth it?
  • Should this be made searchable (aside from the filters for the type etc)? If so, how? (We don't want to needlessly pile on more data to insert during logging)
  • Anything else?
@cornernote
Copy link
Contributor

My thoughts..

Is it worth it?

Yes, it would be really nice to see some of the panel data on its own. It means things like curl dont need their own tables.

Should this be made searchable (aside from the filters for the type etc)? If so, how? (We don't want to needlessly pile on more data to insert during logging)

It would be nice to search things like the curl URL. Perhaps data should have a varchar(255) called keywords. We then ask the panel to give Panel::saveKeywords(), or we change Panel::save() to return an array (eg: ['data'=>$data,'keywords'=>$keywords]). I prefer the later as it allows future changes without changing all the panels.

Anything else?

Nothing I can think of right now. But I'll surely come up with something once its done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants