Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIIP 2023] Bug: Any DAG failure between swrs_import and app_user leaves the database with no permissions #2106

Open
pbastia opened this issue Sep 7, 2022 · 3 comments
Labels
Bug Something isn't working Low Priority

Comments

@pbastia
Copy link
Contributor

pbastia commented Sep 7, 2022

There is an issue where if a DAG fails between cas_ciip_swrs_import and cas_ciip_app_user, then the DAG errors out and the permissions to the swrs schema are not restored.

One avenue to fix that would be to tell Airflow of an error case, where if one of the DAG fails then we still run the cas_ciip_app_user in something equivalent to a finally clause

Keywords: CIIP 2023 cycle

Probability (1-5): 1 (It happened once in 3 years)

Effect (1-5): 4 (new applications can't be created as the swrs data can't be imported)

Steps to reproduce the behaviour:

@pbastia pbastia added the Bug Something isn't working label Sep 7, 2022
@pbastia
Copy link
Contributor Author

pbastia commented Nov 16, 2022

Temporary solution: cycle the pods to restore functionality

@pbastia pbastia changed the title Bug: Any DAG failure between swrs_import and app_user leaves the database with no permissions [CIIP 2023] Bug: Any DAG failure between swrs_import and app_user leaves the database with no permissions Nov 16, 2022
@JoshLarouche
Copy link
Contributor

Adding some framework to input severity and probability of this bug but I'm unfamiliar with the issue directly. @pbastia could you fill those out?

@pbastia
Copy link
Contributor Author

pbastia commented Apr 5, 2023

@JoshLarouche I added some details. The likelihood of this happening is really low (airflow must stop working specifically between 2 specific tasks), and the fix is pretty easy. Still a failure point that was identified and that the team can remove, but this doesn't have to be done immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants