Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release bcdata 0.5.0 #347

Closed
19 of 20 tasks
ateucher opened this issue Dec 11, 2024 · 7 comments
Closed
19 of 20 tasks

Release bcdata 0.5.0 #347

ateucher opened this issue Dec 11, 2024 · 7 comments

Comments

@ateucher
Copy link
Collaborator

ateucher commented Dec 11, 2024

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Polish NEWS
  • usethis::use_github_links()
  • urlchecker::url_check()
  • devtools::build_readme()
  • Precompile vignettes
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • Run test and check with internet turned off
  • revdepcheck::revdep_check(num_workers = 4)
  • Update cran-comments.md
  • git push

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::release()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
  • Share on social media
@Jhydromet
Copy link

Bug has popped up maybe relating to these updates (not sure if bcdata or bcgw). I've confirmed multiple users are experiencing this since yesterday afternoon:

Image

@ateucher
Copy link
Collaborator Author

@Jhydromet can you provide a link for the dataset you're trying access?

@Jhydromet
Copy link

Jhydromet commented Dec 18, 2024

Its occurring for several datasets, but looking at the catalogue landing pages it looks like the error isn't coming from bcdata package:

e.g. BC Wildfire Fire Perimeters - Historical
https://catalogue.data.gov.bc.ca/dataset/22c7cb44-1463-48f7-8e47-88857f207702

EDIT: Turns out the landing page errors I was seeing was due to looking at internal datasets while not logged in.

@bevingtona
Copy link

Same for me this morning. happening with a lot of datasets. Possible not a package issue, but a catalogue issue?

library(bcdata)
#> Warning: package 'bcdata' was built under R version 4.3.3
#> 
#> Attaching package: 'bcdata'
#> The following object is masked from 'package:stats':
#> 
#>     filter

bcdata::bcdc_query_geodata("78ec5279-4534-49a1-97e8-9d315936f08b") |>
  filter(SCHOOL_DISTRICT_NAME %in% c("Greater Victoria", "Prince George","Kamloops/Thompson")) |>
  select(SCHOOL_DISTRICT_NAME) |>
  collect()
#> Error: There was an issue sending this WFS request
#> ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
#> Request:
#>   URL: https://openmaps.gov.bc.ca/geo/pub/wfs
#>   POST fields:
#>     SERVICE=WFS&VERSION=2.0.0&REQUEST=DescribeFeatureType&typeNames=WHSE_TANTALIS.TA_SCHOOL_DISTRICTS_SVW
#>   Content-Type: application/x-www-form-urlencoded
#>   Accept-Encoding: gzip, deflate
#>   Accept: application/json, text/xml, application/xml, */*
#>   User-Agent: https://github.com/bcgov/bcdata
#> Response:
#>   status: HTTP/1.1 500 Internal Server Error
#>   content-type: application/json; charset=utf-8
#>   transfer-encoding: chunked
#>   vary: Origin
#>   vary: Access-Control-Request-Method
#>   vary: Access-Control-Request-Headers
#>   date: Wed, 18 Dec 2024 19:56:58 GMT
#>   server: uvicorn
#>   x-kong-upstream-latency: 37
#>   x-kong-proxy-latency: 0

packageVersion("bcdata")
#> [1] '0.5.0'

Created on 2024-12-18 with reprex v2.0.2

@achubaty
Copy link

achubaty commented Dec 18, 2024

FWIW I am experiencing the same errors using the previous and latest package versions (0.4.1 and 0.5.0).

Looks to only be the queries to the WFS server.

> bcdata::bcdc_get_record("78ec5279-4534-49a1-97e8-9d315936f08b")
B.C. Data Catalogue Record: School Districts of BC
Name: school-districts-of-bc (ID:
 78ec5279-4534-49a1-97e8-9d315936f08b)
Permalink:
 https://catalogue.data.gov.bc.ca/dataset/78ec5279-4534-49a1-97e8-9d315936f08b
Licence: Open Government Licence - British Columbia
Description: The School Districts dataset contains the
 spatial representation (polygon) of the current extent of the
 administrative areas defined under section 176(1) of the School Act for
 the purposes of preservation and promotion of the fundamental principle
 of local autonomy and control of public education at the public and
 governmental levels through locally elected school boards.
Available Resources (1):
 1. WMS getCapabilities request (wms)
Access the full 'Resources' data frame using:
 bcdc_tidy_resources('78ec5279-4534-49a1-97e8-9d315936f08b')
Query and filter this data using:
 bcdc_query_geodata('78ec5279-4534-49a1-97e8-9d315936f08b')

> bcdc_query_geodata('78ec5279-4534-49a1-97e8-9d315936f08b')
Error: There was an issue sending this WFS request
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
Request:
  URL: https://openmaps.gov.bc.ca/geo/pub/wfs
  POST fields:
    SERVICE=WFS&VERSION=2.0.0&REQUEST=DescribeFeatureType&typeNames=WHSE_TANTALIS.TA_SCHOOL_DISTRICTS_SVW
  Content-Type: application/x-www-form-urlencoded
  Accept-Encoding: gzip, deflate
  Accept: application/json, text/xml, application/xml, */*
  User-Agent: https://github.com/bcgov/bcdata
Response:
  status: HTTP/1.1 500 Internal Server Error
  content-type: application/json; charset=utf-8
  transfer-encoding: chunked
  vary: Origin
  vary: Access-Control-Request-Method
  vary: Access-Control-Request-Headers
  date: Wed, 18 Dec 2024 20:04:44 GMT
  server: uvicorn
  x-kong-upstream-latency: 3
  x-kong-proxy-late
 

@ateucher
Copy link
Collaborator Author

I'm going to close this and track in #348

@ateucher
Copy link
Collaborator Author

@Jhydromet thanks for raising this issue. In the future, it helps keep track of, and debug issues if you can open a new issue rather than tagging onto a different one (even if you think they're related), and also provide pasted code rather than a screenshot. Ideally a reprex. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants