Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

\n should not be parsed in strings #32

Closed
vmarkovtsev opened this issue Aug 21, 2018 · 3 comments
Closed

\n should not be parsed in strings #32

vmarkovtsev opened this issue Aug 21, 2018 · 3 comments
Assignees
Labels

Comments

@vmarkovtsev
Copy link

Any JS string which has \n, e.g.

bufferedLog.push(...args, '\n');

contains parsed new lines instead of \n. The desired behavior is passing the string contents verbatim.

@vmarkovtsev vmarkovtsev changed the title \n is parsed in strings \n should not be parsed in strings Aug 21, 2018
@dennwc dennwc added the bug label Aug 21, 2018
@dennwc dennwc self-assigned this Aug 21, 2018
@dennwc
Copy link
Member

dennwc commented Nov 7, 2018

Blocked by bblfsh/sdk#318

@juanjux
Copy link
Contributor

juanjux commented Dec 13, 2018

@dennwc that should not block this issue.

@dennwc
Copy link
Member

dennwc commented Jan 3, 2019

OK, I can confirm that it's unrelated to that issue.

Usually, drivers provide an escaped (raw) string literal in the native AST. But for this driver, we used the unescaped value (parsed).

I will change it to use the raw value in Native/Annotated and parse it for Semantic (like in all other drivers).

dennwc pushed a commit to dennwc/javascript-driver that referenced this issue Jan 3, 2019
dennwc pushed a commit to dennwc/javascript-driver that referenced this issue Jan 3, 2019
@dennwc dennwc closed this as completed in 2ac100c Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants