Question: how to get the node's token and internal type

[vmarkovtsev]

Before:

uast.Node.Token
uast.Node.InternalType
uast.Node.StartPosition
uast.Node.EndPosition

After (Annotated mode)?..

[dennwc]

token := uast.TokenOf(node)

typ = uast.TypeOf(node)

pos := uast.PositionsOf(node)
start := pos.Start()
end := pos.End()

See bblfsh/sdk#318 regarding the token reliability.

[vmarkovtsev]

👍

[dennwc]

Reopening until documentation is updated

[bzz]

Where in docs do you @dennwc think this and #99 does belong to? The only I can think of right now is https://docs.sourced.tech/babelfish/using-babelfish/grpc-usage-example.

Rationale - it seems too advanced for https://docs.sourced.tech/babelfish/using-babelfish/clients but https://docs.sourced.tech/babelfish/using-babelfish/advanced-usage does not have any code.

Please, let me know what would be the best place and I'll be happy to add it there.

[juanjux]

Outside of the go client godoc, probably the right place would be the clients documentation page already has a Go example it won't hurt to add this there too and I don't think getting the token or position is very advanced. I'll open a PR.

[vmarkovtsev]

@dennwc @bzz I've got

cannot use element (type nodes.Node) as type nodes.Object in argument to "gopkg.in/src-d/hercules.v7/vendor/gopkg.in/bblfsh/sdk.v2/uast".TokenOf: need type assertion

So to get the token you need to

uast.TokenOf(node.(nodes.Object))

The same for PositionsOf

[juanjux]

Yes. That's how I needed to document it. It's certainly not beautiful.

[dennwc]

Let's change it to node.Node instead of nodes.Object and document that it returns an empty string if it's not an object.

[creachadair]

Does bblfsh/sdk#363 resolve this issue?

[vmarkovtsev]

It seems so. I will use the new release in Hercules and report any left problems separately, ok?