You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Following the meeting about upgrading major dependencies, we discussed the no-import-assign rule coming from eslint-config-airbnb to v19.
This anti-pattern of importing something into a namespace and assigning that namespace a different value is not recommended.
We only use this anti-pattern in our unit test cases, this PR will take care of places where we use this pattern so that we can later enforce this by upgrading to the new major version of eslint-config-airbnb.
Describe the solution you'd like
Identify a solution that will allow our unit tests to not use the above-described anti-pattern.
Identify all the files that use the anti-pattern described above (marked with no-import-assign error).
Apply the found solution to all the identified files.
To identify the files
checkout into renovate/eslint-config-airbnb-19.x with git checkout renovate/eslint-config-airbnb-19.x
run yarn && yarn test:lint
Locate all files with no-import-assign error description on the output
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
DarioR01
added
Refinement Needed
This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
technical-work
Technical debt, support work and building new technical tools and features
and removed
Refinement Needed
This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
labels
Mar 30, 2022
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Following the meeting about upgrading major dependencies, we discussed the no-import-assign rule coming from eslint-config-airbnb to v19.
This anti-pattern of importing something into a namespace and assigning that namespace a different value is not recommended.
We only use this anti-pattern in our unit test cases, this PR will take care of places where we use this pattern so that we can later enforce this by upgrading to the new major version of eslint-config-airbnb.
Describe the solution you'd like
To identify the files
git checkout renovate/eslint-config-airbnb-19.x
yarn && yarn test:lint
Alternatively
Alternatively
git checkout renovate/eslint-config-airbnb-19.x
yarn && yarn test:lint
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Testing notes
[Tester to complete]
Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc
Checklist
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: