Selection is barely visible

[cubranic]

In spacemacs master with zenburn theme, the selection is indicated by just a shade darker background. (screenshot attached) This makes it difficult to see, and I often find myself searching for it. I understand that you don't want to use a reverse highlight for this as being too bright, but have you considered giving it a bit of a colour hue to make it easier to find on the screen?

[lawreenas]

+1
I also have trouble seeing selection, especially when using expand-region.

[bbatsov]

I guess we should make it configurable, as I'm pretty happy with the current colours (I like subtle selection highlighting), but I know some people are unhappy with it.

I'd accept some defcustom that controls this.

[cubranic]

For reference, the original (Vim) Zenburn uses the following colours for visual selection (src):

Style	contrast	Fg	Bg
new	default	??	#2f2f2f
new	high	??	#0f0f0f
old	default	#233323	#71d3b4
old	alternate	#000000	#71d3b4

[bbatsov]

Well, the colours it uses are not that important I guess - the important take-away is that it has several versions. I'm fine with adopting a similar approach, but I have 0 time to work on this myself.

[ofenerci]

How could I make a more visible? What changes do I need to make it in my .emacs file.

[krotonic]

You can add region to custom-theme-set-faces in order to change the selection fg & bg color.

(zenburn-with-color-variables  
  (custom-theme-set-faces  
    'zenburn  
    `(region ((t (:foreground ,zenburn-fg :background ,zenburn-bg))))))