make data runtime-only to align with ecosystem norms
#2977
Comments
|
I think this makes sense to do - it was a mistake that we used Ideally we should introduce a flag to control this behaviour to make migration easier. Introduce the flag (I don't really mind what default we use), and delete the flag a release or two later when people have had an opportunity to migrate. Happy to review a PR doing this! |
|
I can send a PR but I may not get to it for a few weeks. If anyone else is motivated in the meantime, go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the current rules_rust rules, the
dataattribute is available both at compile time and at runtime whereas thecompile_datais just available at runtime. There is no attribute that describes runtime-only dependencies. This is unfortunate; changing runtime dependencies shouldn't force a recompilation and relinking of an executable.In order to align with the rest of the bazel ecosystem, we should change
datato not be available at compile time. This will be a breaking change, but it's worth it.The text was updated successfully, but these errors were encountered: