Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ktlint version #1181

Open
ratnikov opened this issue Jun 17, 2024 · 1 comment
Open

Update ktlint version #1181

ratnikov opened this issue Jun 17, 2024 · 1 comment

Comments

@ratnikov
Copy link

Hey folks,

I noticed that the bundled ktlint version is quite a bit behind the latest (0.49.1 vs 1.3.0) which causes quite a bit of a linting discrepancy. Do you have a suggestion on how I should approach this? Ideas I have so far:

  1. Maybe there's a way to override version in rules_kotlin, though I'm not sure exactly how...
  2. Send a PR to bump the version (that's a bit tricky since my company is still figuring out the CLA process. :( )
  3. Your suggestion here...

Thanks!

@Bencodes
Copy link
Collaborator

@ratnikov I put up a PR upgrading the internal version #1184

The infrastructure is there to support dynamically setting remote versions via kotlin_repositories, wouldn't be hard to extend that to support KtLint as well. Happy to review a PR for this if you want to take a stab at putting one up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants