Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2 is no longer in Msys2 on Windows VM #2112

Open
crt-31 opened this issue Nov 18, 2024 · 1 comment
Open

libxml2 is no longer in Msys2 on Windows VM #2112

crt-31 opened this issue Nov 18, 2024 · 1 comment

Comments

@crt-31
Copy link

crt-31 commented Nov 18, 2024

We are attempting to reenable windows CI int rules_scala (bazelbuild/rules_scala#1649).

The rules_scala tests require libxml2 to be available in MSYS2. But due to some changes in msys2's default package deps over last year, libxml2 isn't a default Msys2 package anymore.

I'm not sure how the VM state gets reused or reset between runs, so first question is:

  • Is it OK to just run pacman ourselves to install libxml2 in the batch_commands of the presubmit.yml? (This wouldn't affect future runs would it?)

Or, would it be better to add libxml2 to the list of msys2 packages that get initially setup onto the VM (see setup-windows.ps1)

Or, possibly, add a config option to the presubmit.yml that allows us to declare extra msys2 packages we require and let the CI system handle it.

Please advise on which is the best way forward,
Thanks.

@meteorcloudy
Copy link
Member

Is it OK to just run pacman ourselves to install libxml2 in the batch_commands of the presubmit.yml? (This wouldn't affect future runs would it?)

Yes, this is perfectly fine and encouraged. The Windows VMs are destroyed after each build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants