Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a previous version of MSVC build tools #1968

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

meteorcloudy
Copy link
Member

Fixes #1967

There is no way to prevent installing the latest version, so we remove it manually.

There is no way to prevent installing the latest version, so we remove
it manually.
@meteorcloudy meteorcloudy merged commit 68dea4f into bazelbuild:master Jun 7, 2024
1 check passed
@fmeum
Copy link
Contributor

fmeum commented Jun 7, 2024

@meteorcloudy We found this workaround to fix the issue while still using the latest MSVC version: actions/runner-images#10004 (comment)

@meteorcloudy
Copy link
Member Author

Oh, do you mean adding /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR? That would only work for Bazel binaries having this change? Otherwise, we still need to ask users to upgrade vcruntime140.dll, right?

@meteorcloudy
Copy link
Member Author

I'm hoping Microsoft could release a new MSVC version that fixes this issue.. otherwise, we'll have to give people a heads-up before switching to the latest MSVC (maybe in Bazel 8).

@fmeum
Copy link
Contributor

fmeum commented Jun 7, 2024

Oh, do you mean adding /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR? That would only work for Bazel binaries having this change? Otherwise, we still need to ask users to upgrade vcruntime140.dll, right?

Yes. For building Bazel we would only need to add the copt, for Bazel itself we either need to add this to the toolchain or have users deal with the fallout themselves.

We noticed this because our protoc built from source would fail during the build.

@meteorcloudy
Copy link
Member Author

Okay, I'll wait a bit on actions/runner-images#10004 to see if there is any official recommended solution. In general, we probably shouldn't add too many random options in the default toolchain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bazel binaries built with the latest MSVC version (14.40.33807) crash with older vcruntime
3 participants