-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep version in sync between MODULE.bazel and version.bzl #386
Comments
The natural way to do so would be to extract
Unfortunately, this means we need to depend on buildozer, and while this is easy enough to do via
I believe that I'm hitting bazel-contrib/rules_go#3265 Alternatively, we could avoid the problem trivially if there were an official buildtools module in the central registery - but it doesn't exist yet. Current work in progress is sitting at https://github.com/tetromino/bazel-skylib/tree/version_consistency a.k.a. #396 |
@tetromino I just submitted a PR that should add support for |
rules_go 0.34.0 is now available in the register and should support |
0.34.0 was released in July. I think your fix is in 0.35.0, which isn't in the register yet :) |
Given the experimental status of rules_go's bzlmod support as well as the BCR, we decided to continuously push updates to it, modifying existing versions if necessary - so 0.34.0 is indeed what you want. That will of course change when the BCR and Bzlmod support in Bazel become more stable. |
Hmm. I've confirmed that 0.34.0 that got downloaded by bazel from BCR into my external/ dir does have the fix, but I'm still hitting the same error -
|
Ah, I now understand the problem: I also need bazel-contrib/bazel-gazelle#1331 Time for |
Gazelle 0.26.0 should have the fix, but it was updated in place so you might need to clean. |
Reminder to myself: after merging #385, we will need some sort of a diff test to keep the module version and the
version.bzl
version in sync; neither file can load the other - MODULE.bazel prohibitsload
statements.The text was updated successfully, but these errors were encountered: