-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gazebosim/sdformat and its dependencies to BCR #3172
Add gazebosim/sdformat and its dependencies to BCR #3172
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (gz-math, gz-utils, sdformat) have been updated in this PR. Please review the changes. |
While testing this locally,
I think we need to add |
@bazel-io skip_check unstable_url |
1 similar comment
@bazel-io skip_check unstable_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Udaya! I suggested a few changes for the presubmit setups. Other than that, we should wait for your upstream PRs in gz-math and sdformat to be submitted, make releases for all of those packages and then request this PR to be merged in.
Signed-off-by: udayaprakash <[email protected]>
Signed-off-by: udayaprakash <[email protected]>
Signed-off-by: udayaprakash <[email protected]>
Signed-off-by: udayaprakash <[email protected]>
Ready for review again, presubmits pass: @shameekganguly or @mjcarroll for a final pass. @meteorcloudy for merging |
To be reviewed by @shameekganguly or @mjcarroll. The version name I chose is a
<date>.1
format since this doesn't seem to be a stable release.