New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carryover items from 2.0.33 code review [JIRA: RIAK-2990] #217

Open

matthewvon opened this issue Nov 21, 2016 · 0 comments

Labels

Contributor

matthewvon commented Nov 21, 2016 •

edited

Loading

riak_object's KeyGetBucket() and its support routines not reviewed since unused in this branch.
riak_object_test.cc only returns true for tests of ValueGetLastModTime(). Need some negative tests.
too many "magic constants" in the code. prefer to have descriptive names.
declare ExpiryModule::CreateExpiryModule() as a friend, which forces everyone to allocate via your factory method. The only complication is in the unit tests

Basho-JIRA changed the title ~~Carryover items from 2.0.33 code review~~ Carryover items from 2.0.33 code review [JIRA: RIAK-2990]

Basho-JIRA added the JIRA: To Do label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment