Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Move isValidPrefix methods to provider injector packages #234

Open
2 tasks done
csatib02 opened this issue Jun 7, 2024 · 0 comments
Open
2 tasks done

Move isValidPrefix methods to provider injector packages #234

csatib02 opened this issue Jun 7, 2024 · 0 comments
Assignees
@csatib02
Labels
kind/enhancement Categorizes issue or PR as related to an improvement.

Comments

@csatib02
Copy link
Member

csatib02 commented Jun 7, 2024

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Currently the Secrets-webhook repo contains methods for checking provider prefixes e.g.: https://github.com/bank-vaults/secrets-webhook/blob/44e97a55e446774eb1e19dc3d782db77c37f3a51/pkg/provider/vault/provider.go#L72C1-L74C2

Proposed Solution

Move these to the corresponding injector package, making it a single source of truth.

Alternatives Considered

No response

Additional Information

No response
@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label Jun 7, 2024
@csatib02 csatib02 self-assigned this Jun 7, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Aug 11, 2024
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Aug 11, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csatib02 csatib02

Labels
kind/enhancement Categorizes issue or PR as related to an improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatib02