implement await/async, search, sort, thread, list-status, esearch, esort #52

filiphanes · 2020-07-24T17:05:59Z

fix FetchCommand.wait_data()
don't request capability when server sends it
support multiple untagged response types for LIST-STATUS and FETCH VANISHED
add response parsers
update README.rst

I have tested it only against Dovecot 2.4.devel

Fixes #47
Fixes #51
Fixes #45
Fixes #6

- fix FetchCommand.wait_data() - don't request capability when server sends it - support multiple untagged response types for LIST-STATUS and FETCH VANISHED - add response parsers - update README.rst

hudcap · 2020-11-10T18:16:46Z

Is there any update on this?
I'm getting

    with (yield from self.state_condition):
TypeError: 'Condition' object is not iterable

unless I change all references to self.state_condition to use the async/await keywords.

I didn't try too hard to debug, since this PR should fix it.

darkrain42

I still get odd test failures, but with the suggested changes, it gets further than:

Traceback (most recent call last):
  File "/home/paul/src/aioimaplib/aioimaplib/tests/imapserver.py", line 172, in execute_section
    with (await self.state_condition):
TypeError: object Condition can't be used in 'await' expression

aioimaplib/tests/imapserver.py

TheBlusky · 2021-03-31T19:56:05Z

Is there any plan on implementing this ?

Co-authored-by: Paul Aurich <[email protected]>

bamthomas · 2021-04-09T16:48:34Z

Thank you for your feedbacks, addings and thoughts.

But I'm sorry, I cannot merge this PR :

tests are broken (and not one but a lot I'm not even sure that the library is still working properly)
there are duplicated code (like quoted/unquoted)
commented code
constants removed
and untested code

Lithimlin · 2021-04-09T18:12:25Z

Just letting people know that I'm also getting a similar error which I believe to be related:

File ".../env/lib/python3.9/site-packages/aioimaplib/aioimaplib.py", line 618, in wait
    with (yield from self.state_condition):
TypeError: 'Condition' object is not iterable

Lithimlin · 2021-04-09T19:59:50Z

But I'm sorry, I cannot merge this PR :
[...]
* there are duplicated code (like quoted/unquoted)
* commented code
* constants removed

Not sure what you mean by this. When I'm looking through the diff of the PR, I see no such things and while one constant's name has been removed, it was the CR constant which was only used once in the code.

Otherwise, this PR look pretty solid

filiphanes · 2021-04-09T20:13:39Z

@bamthomas is right,

tests are broken, because I have tested it only against Dovecot server from my other project https://github.com/filiphanes/jmap-proxy-python/ which is using all of new code
where do you see duplicated code in quoted/unquoted?
I will remove commented code
constant CRLF replaced in 2 places to avoid resolving global variable and IMHO b'\r\n' is better readable and obvious
IMAP4_PORT and IMAP4_SSL_PORT were used only for default argument values, which again is more obvious to put plain values there, but I can revert it, if @bamthomas want
yes, tests should be fixed

bamthomas · 2021-04-09T21:16:21Z

what I mean @Lithimlin is pretty clear, there is no opinion or whatever here, only facts :

tests are broken : look above : do you see one commit with a valid green tick ? no
quoted/unquoted methods are duplicated functions with only a small diff before it wasn't the case
there is commented code because it was annoying
even if there was only one instance of CRLR it was more clear than \r\n and showed intention why remove this ?
and all the bunch of utility functions (that are I am sure are useful) but code without tests are debt (Michael Feathers)

so when all of this will be fixed then I could eventually merge.

Lithimlin · 2021-04-09T21:42:24Z

Sorry if there was a misunderstanding. I never questioned the tests failing, only the points I quoted. The tests are obviously failing.

I still don't see any duplicated or commented-out code. Or do you mean documentation comments in the code?It seems @filiphanes is also confused about this part, and I also agree with them regarding the CRLF constant.

bamthomas

I won't take your copyright.
Either every ten committers are here or either none.
My name is here because I started this and still maintaining it.

bamthomas · 2021-04-09T21:20:13Z

aioimaplib/aioimaplib.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 #    aioimaplib : an IMAPrev4 lib using python asyncio
 #    Copyright (C) 2016  Bruno Thomas
+#    Copyright (C) 2020  Filip Hanes


:)
do you know that there has been 10 commiters and you are the first to do this ?

no :) I thought that it is normal when someone adds significant portion of functionality. Are there some limiting consequences for you?

bamthomas · 2021-04-10T12:47:24Z

I pulled the branch and yes the tests are green. But I can't merge this. I'm sorry, even if I think that there may be value in it.
there are too much mixed things and added functionalities without any tests.

So for now I'm blocked with this PR.
I can propose you to have a jitsi meeting to talk about this if you want. You can come with @Lithimlin if you want, and I can also join @pblayo that is the second committer on the lib. What do you think ?

Lithimlin · 2021-04-10T13:07:50Z

Since I have no real connection to either of you and am just eagerly waiting for an update on this not functional library I'd rather stay out of the discussion, though I appreciatethe invitation.
I only looked over the PR since I wanted to see what was changed. I find the changes personally to look very good and be codedina good way,however, I have not yet had the opportunity to test any of the changes.

filiphanes · 2021-04-10T13:12:03Z

@bamthomas ok, I understand, I am willing to work on it, and would appreciate some help with tests

Meeting would be great, I would like to discuss these updates, you can send me email.

bamthomas · 2021-04-10T13:27:59Z

see the #59 is what we would expect.

bamthomas · 2021-04-15T08:35:35Z

@filiphanes I tried the form on your website but it says that the mail server is unreachable.
You can send me an email to bruno on the domain barreverte.fr

filiphanes added 4 commits July 24, 2020 18:59

implement await/async, search, sort, thread, list-status, esearch, esort

c546e42

- fix FetchCommand.wait_data() - don't request capability when server sends it - support multiple untagged response types for LIST-STATUS and FETCH VANISHED - add response parsers - update README.rst

async/await in tests, examples, add python 3.8 to travis

50d44a5

fix fetch vanished, parser regexps

352d425

add uid_move, get/setmetadata

f62cf8c

darkrain42 reviewed Feb 16, 2021

View reviewed changes

aioimaplib/tests/imapserver.py Outdated Show resolved Hide resolved

aioimaplib/tests/imapserver.py Outdated Show resolved Hide resolved

darkrain42 mentioned this pull request Feb 16, 2021

['+ idling from'] from imap_client.wait_server_push() #30

Closed

filiphanes and others added 2 commits April 8, 2021 17:33

Update aioimaplib/tests/imapserver.py

5622192

Co-authored-by: Paul Aurich <[email protected]>

Update aioimaplib/tests/imapserver.py

397bb4b

Co-authored-by: Paul Aurich <[email protected]>

fix typos, test

7060245

bamthomas requested changes Apr 10, 2021

View reviewed changes

bamthomas mentioned this pull request Apr 10, 2021

aioimap: using await/async syntax #59

Merged

fix some tests

69e921a

constant CRLF

7616f75

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement await/async, search, sort, thread, list-status, esearch, esort #52

implement await/async, search, sort, thread, list-status, esearch, esort #52

filiphanes commented Jul 24, 2020 •

edited

Loading

hudcap commented Nov 10, 2020

darkrain42 left a comment

TheBlusky commented Mar 31, 2021

bamthomas commented Apr 9, 2021 •

edited

Loading

Lithimlin commented Apr 9, 2021

Lithimlin commented Apr 9, 2021

filiphanes commented Apr 9, 2021

bamthomas commented Apr 9, 2021

Lithimlin commented Apr 9, 2021 •

edited

Loading

bamthomas left a comment

bamthomas Apr 9, 2021

filiphanes Apr 10, 2021

bamthomas commented Apr 10, 2021

Lithimlin commented Apr 10, 2021

filiphanes commented Apr 10, 2021

bamthomas commented Apr 10, 2021

bamthomas commented Apr 15, 2021

implement await/async, search, sort, thread, list-status, esearch, esort #52

Are you sure you want to change the base?

implement await/async, search, sort, thread, list-status, esearch, esort #52

Conversation

filiphanes commented Jul 24, 2020 • edited Loading

hudcap commented Nov 10, 2020

darkrain42 left a comment

Choose a reason for hiding this comment

TheBlusky commented Mar 31, 2021

bamthomas commented Apr 9, 2021 • edited Loading

Lithimlin commented Apr 9, 2021

Lithimlin commented Apr 9, 2021

filiphanes commented Apr 9, 2021

bamthomas commented Apr 9, 2021

Lithimlin commented Apr 9, 2021 • edited Loading

bamthomas left a comment

Choose a reason for hiding this comment

bamthomas Apr 9, 2021

Choose a reason for hiding this comment

filiphanes Apr 10, 2021

Choose a reason for hiding this comment

bamthomas commented Apr 10, 2021

Lithimlin commented Apr 10, 2021

filiphanes commented Apr 10, 2021

bamthomas commented Apr 10, 2021

bamthomas commented Apr 15, 2021

filiphanes commented Jul 24, 2020 •

edited

Loading

bamthomas commented Apr 9, 2021 •

edited

Loading

Lithimlin commented Apr 9, 2021 •

edited

Loading