Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to list examples broken in on of the examples #812

Open
danieltomasz opened this issue May 18, 2024 · 5 comments
Open

Link to list examples broken in on of the examples #812

danieltomasz opened this issue May 18, 2024 · 5 comments
Labels
documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you!

Comments

@danieltomasz
Copy link

Here is the link https://arc.net/l/quote/arklfivg
It should point to https://bambinos.github.io/bambi/notebooks/ (the linked bad link is https://bambinos.github.io/bambi/main/examples.html - contain "main" in address )

@tomicapretto
Copy link
Collaborator

@danieltomasz thanks for the issue!

@tomicapretto tomicapretto added documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you! labels May 20, 2024
@danieltomasz
Copy link
Author

danieltomasz commented May 20, 2024

@tomicapretto Would you like me to pull request ?
Also I would propose to explicitly add links (to download from bambi repo) or simulate data to this tutorial,
https://bambinos.github.io/bambi/notebooks/getting_started.html
not assuming that someone knows exactly which form data should have,
it is easier to just copy/paste example that just works for someone who is learning from the web (but I can create separate new issue for that),

@tomicapretto
Copy link
Collaborator

That would be awesome! Feel free to tag me in the PR so I can review :)

@CodingWithError
Copy link

hey, I am new Here I would like to work on this can you give me some explanation about this.

@tomicapretto
Copy link
Collaborator

@CodingWithError

If you go here https://bambinos.github.io/bambi/notebooks/radon_example.html#:~:text=Bambi%20examples%20section, you'll see it links to https://bambinos.github.io/bambi/main/examples.html, but it should link to https://bambinos.github.io/bambi/notebooks/, without the main.

To modify that, you need to modify this notebook https://github.com/bambinos/bambi/blob/main/docs/notebooks/radon_example.ipynb

The text with the broken link is the one highlighted here

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue If you want to contribute but are not sure where to get started, this issue is for you!
Projects
None yet
Development

No branches or pull requests

3 participants