Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿ a11y(dropdown): start focus from selected option #1446

Closed
1 task done
hirsch88 opened this issue Sep 5, 2024 · 2 comments · Fixed by #1448
Closed
1 task done

♿ a11y(dropdown): start focus from selected option #1446

hirsch88 opened this issue Sep 5, 2024 · 2 comments · Fixed by #1448
Assignees
@m4rc0z
Labels
🐛 bug Something isn't working
Milestone
♿️ Accessibility

Comments

@hirsch88
Copy link
Member

hirsch88 commented Sep 5, 2024

Description of this issue

If nothing is selected when opening this listbox, the first option is focused. If there are selected options, the first selected option is focused when opening.

How to fix it

--

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hirsch88 hirsch88 added the 🐛 bug Something isn't working label Sep 5, 2024
@hirsch88 hirsch88 added this to the ♿️ Accessibility milestone Sep 5, 2024
@hirsch88 hirsch88 mentioned this issue Sep 5, 2024
Closed
1 task
@m4rc0z
Copy link
Collaborator

m4rc0z commented Sep 5, 2024

/cib

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Branch fix/issue-1446 created!

github-actions bot added a commit that referenced this issue Sep 5, 2024
@github-actions
Create PR for #1446
0c445a4
@github-actions github-actions bot mentioned this issue Sep 5, 2024
Merged
hirsch88 added a commit that referenced this issue Sep 12, 2024
@github-actions @baldummy @hirsch88
♿ a11y(dropdown): start focus from selected option (#1448)
6c7a3f6 
* Create PR for #1446

* feat(a11y-dropdown): focus selected option when opening dropdown popup to improve a11y with keyboard navigation

* feat(a11y-dropdown): move to option list to be consumed by other parts (like combobox) in the future

* fix(dropdonw): adjust selection

* chore: fix condtion

* chore: update ts definitions

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marco Zirkenbach <[email protected]>
Co-authored-by: Gery Hirschfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4rc0z m4rc0z

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
♿️ Accessibility
Development

Successfully merging a pull request may close this issue.

♿ a11y(dropdown): start focus from selected option baloise/design-system
2 participants
@hirsch88 @m4rc0z