Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♿ a11y(productslider): Link List #1417

Closed
1 task done
carolabes opened this issue Jun 11, 2024 · 3 comments
Closed
1 task done

♿ a11y(productslider): Link List #1417

carolabes opened this issue Jun 11, 2024 · 3 comments
Assignees
@hirsch88
Labels
🐛 bug Something isn't working

Comments

@carolabes
Copy link

Description of this issue

  • screenreader does not recognize how many items the list contains
productslider-linklist

How to fix it

  • implement as linklist

Additional Information

Level A
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carolabes carolabes added the ✨ feature New feature or request label Jun 11, 2024
@hirsch88 hirsch88 added 🐛 bug Something isn't working and removed ✨ feature New feature or request labels Aug 8, 2024
@hirsch88 hirsch88 self-assigned this Aug 16, 2024
@hirsch88
Copy link
Member

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch fix/issue-1417 created!

github-actions bot added a commit that referenced this issue Aug 16, 2024
@github-actions
Create PR for #1417
b911eff
@github-actions github-actions bot mentioned this issue Aug 16, 2024
Closed
hirsch88 added a commit that referenced this issue Sep 5, 2024
@github-actions @hirsch88
♿ a11y(tabs, carousel): keyboard interaction (#1432)
d8c2bc4 
* Create PR for #1425

* fix(tabs): only show line when value exists

* fix(tabs): only show line when value exists

* fix(tabs): improve keyboard navigation according to a11y criterias

* chore: fix typo

* Create PR for #1417

* fix(carousel): implement role list and listitem to improve screenreaders

* fix(carousel): add missing aria controls

* fix(carousel): improve keyboard inputs and a11y criterias

* fix(carousel): improve keyboard inputs and a11y criterias

* chore: add missing unit test

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
@hirsch88
Copy link
Member

hirsch88 commented Sep 6, 2024

ready to be released with the next version after 16.3.0

@hirsch88 hirsch88 closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirsch88 hirsch88

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♿ a11y(productslider): Link List baloise/design-system
2 participants
@hirsch88 @carolabes