Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gRPC] Enable support to configure socket timeout in service/client endpoint #11276

Closed
daneshk opened this issue Nov 8, 2018 · 2 comments
Closed
Assignees
Labels
Team/StandardLibs All Ballerina standard libraries Type/Bug
Milestone

Comments

@daneshk
Copy link
Member

daneshk commented Nov 8, 2018

Description:
Currently there is no way of defining timeout value for gRPC service and client when initializing. We need to give support to define timeout as endpoint configuration.

@daneshk daneshk changed the title [gRPC] Implement resiliency support in service/client [gRPC] Enable support to configure socket timeout in service/client connection Nov 9, 2018
@daneshk daneshk changed the title [gRPC] Enable support to configure socket timeout in service/client connection [gRPC] Enable support to configure socket timeout in service/client endpoint Nov 9, 2018
@daneshk
Copy link
Member Author

daneshk commented Dec 19, 2018

With the fix #12845,
Server socket timeout can be configured like,

listener grpc:Listener ep = new grpc:Listener(9090, config = {
        timeoutMillis : 1000
});

Client socket timeout can be configured like,

HelloWorldBlockingClient ep = new("http://localhost:9090", config = {
     timeoutMillis : 1000
});

NOTE: Server socket timeout is not supported currently due to an issue wso2/transport-http#284 in transport layer. Server waits forever regardless of timeout time.

@daneshk daneshk self-assigned this Dec 21, 2018
@daneshk daneshk added this to the 0.990.1 milestone Dec 21, 2018
@daneshk
Copy link
Member Author

daneshk commented Dec 21, 2018

Fixes in Ballerina side is merged to upstream. Hence closing this issue. We will fix transport issue addressed in wso2/transport-http#284

@daneshk daneshk closed this as completed Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/StandardLibs All Ballerina standard libraries Type/Bug
Projects
None yet
Development

No branches or pull requests

1 participant