Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max add option #231

Open
agualis opened this issue Dec 4, 2024 · 1 comment
Open

Max add option #231

agualis opened this issue Dec 4, 2024 · 1 comment
Assignees

Comments

@agualis
Copy link
Collaborator

agualis commented Dec 4, 2024

We removed the old Maximize option after refactoring to explicit SDK Proportional handlers.

It was using calculateProportionalAmounts helper form the SDK which does not work nicely with the explicit SDK Proportional handlers (as they expect exact bpt out instead of tokens in).

Users can always maximize clicking the wallet icon, although the amounts will go over the balance if they click the wrong one.

This ticket is about exploring better UX for maximizing (check the old optimize code in useProportionalInputs for ideas).

@garethfuller
Copy link
Contributor

cc @uiuxxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants