-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix add liquidity proportional with 0 slippage failing #552
Comments
Here you have some concrete info to debug better. User Address: The new state is this one in that block : In the specific case of proportional adds for v3 boosted pools we use So from the FE we send the following query when the user maximises USDC balance (409248):
We get this query output:
with that, we build the tx calldata with (slippage 0% by default):
|
After some discussion we're under the impression this is not caused by filling out user maxBalance, but it's just a side effect of addLiquidityBoosted queries not being 100% precise. |
Fixed on the FE ✅ |
Reported by @gosuto-inzasheru
pool
0x10a04efba5b880e169920fd4348527c64fb29d4d
eoa
0x4BC8121278056BFCaC2BD14D455659224d6dDf48
slippage 0% fails
slippage 1% succeeds
gosuto.eth
1 hour ago
ok then im wondering why it didnt work with slippage set to 0
there are no swaps in this pool that could have changed the proportional price
assumption: rounding issue?
The text was updated successfully, but these errors were encountered: