Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] run on connection only activates if the device is unlocked #1

Open
4rtemis-4rrow opened this issue Oct 31, 2024 · 7 comments

Comments

@4rtemis-4rrow
Copy link

title says it all

device locked, USB connected: activate

device unlocked, USB connected: don't activate

@4rtemis-4rrow
Copy link
Author

btw, great app, seriously

can I also suggest adding some test options? so that the user can test the various triggers without having it destroy everything? just show a notification like "trigger X activated" or something

@bakad3v
Copy link
Owner

bakad3v commented Oct 31, 2024

It's really strange, I will check it out. Probably USB connection trigger was undertested, I have not so much real devices for tests and it can't be tested with emulators.
Message text and title are messed up, it doesn't work when device unlocked or locked?

@bakad3v
Copy link
Owner

bakad3v commented Oct 31, 2024

can I also suggest adding some test options? so that the user can test the various triggers without having it destroy everything? just show a notification like "trigger X activated" or something

You can just use in-app logs and don't mark anything for deletion. It will write some message if triggers were activated. I think I need to make it clear in the README.

@bakad3v
Copy link
Owner

bakad3v commented Oct 31, 2024

title says it all

device locked, USB connected: activate

device unlocked, USB connected: don't activate

Does other triggers work correctly? Does accessibility service work? Are there any errors in logs? What version of app did you use?

@bakad3v bakad3v self-assigned this Oct 31, 2024
@bakad3v bakad3v added the bug Something isn't working label Oct 31, 2024
@bakad3v bakad3v removed their assignment Oct 31, 2024
@4rtemis-4rrow
Copy link
Author

wait, no

this is not a bug, this is a feature request, just don't activate the USB trigger if the device was unlocked when the USB was plugged in, there is no bug m8, sorry for the confusion

@bakad3v bakad3v added feature request and removed bug Something isn't working labels Oct 31, 2024
@bakad3v
Copy link
Owner

bakad3v commented Oct 31, 2024

wait, no

this is not a bug, this is a feature request, just don't activate the USB trigger if the device was unlocked when the USB was plugged in, there is no bug m8, sorry for the confusion

Ok, I think I can add this feature, though it can somewhat reduce security, so it will not be default behavior.

@4rtemis-4rrow
Copy link
Author

tysm

and again, seriously, good job on this app, it's hella good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants